feat(s3): add s3 support for backup storage #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Maillot <[email protected]>
hairmare
reviewed
Jan 23, 2024
Co-authored-by: Lucas Bickel <[email protected]>
Signed-off-by: Valentin Maillot <[email protected]>
hairmare
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Did you consider doing it in two containers as doxed here? The RH way might make for a more optional mc cli experience in case we want this image to keep a low footprint in existing installs.
LGTM
eyenx
approved these changes
Jan 25, 2024
paraenggu
reviewed
Jan 26, 2024
oh wow, nop, not even considered that. Shall I go that way? That would be fine for me. Then we would not have to care about modifying the script anyway. |
Signed-off-by: Valentin Maillot <[email protected]>
|
i'll go this way for now, let's see if we want to improve that in the future! |
vmaillot
added a commit
that referenced
this pull request
Feb 29, 2024
* feat(s3): add s3 support for backup storage * feat(Dockerfile): use mc RPM instead of binary directly * feat(backup.sh): use mcli instead of mc * chore(README): add link to MinIO object expiration configuration doc Signed-off-by: Valentin Maillot <[email protected]> --------- Signed-off-by: Valentin Maillot <[email protected]> Co-authored-by: Lucas Bickel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://zammad.adfinis.com/#ticket/zoom/27839