Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: also update table summaries on table question change #1152

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

open-dynaMIX
Copy link
Member

This makes sure a newly applied summary config leads to the generation of all the summaries. This has the potential of timing out, if there is a massive amount of Answers. We expect them to be in the lower 100s, so this doesn't justify an async approach.

@open-dynaMIX open-dynaMIX force-pushed the update_summary_on_q_change branch 2 times, most recently from edacec9 to 40484e0 Compare November 21, 2024 08:26
@open-dynaMIX open-dynaMIX changed the title feat: also update table summaries on tabel question change feat: also update table summaries on table question change Nov 21, 2024
This makes sure a newly applied summary config leads to the generation
of all the summaries. This has the potential of timing out, if there is
a massive amount of Answers. We expect them to be in the lower 100s, so
this doesn't justify an async approach.
@open-dynaMIX open-dynaMIX force-pushed the update_summary_on_q_change branch from 40484e0 to bf49b0a Compare November 21, 2024 09:21
@open-dynaMIX open-dynaMIX requested a review from winged November 21, 2024 10:17
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@open-dynaMIX open-dynaMIX merged commit 90227a5 into adfinis:main Nov 21, 2024
6 checks passed
@open-dynaMIX open-dynaMIX deleted the update_summary_on_q_change branch November 21, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants