Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember breaking updates #1080

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Ember breaking updates #1080

merged 5 commits into from
Nov 18, 2024

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented May 28, 2024 •
edited
Loading

  • ember-caluma needs ember-power-select v8, otherwise build errors occur

closes #1078, #971

@Yelinz Yelinz force-pushed the ember-breaking-updates branch 4 times, most recently from 4bca12c to 9398af3 Compare November 15, 2024 15:11
@Yelinz Yelinz force-pushed the ember-breaking-updates branch from 9398af3 to 0f7d83a Compare November 15, 2024 15:17
@Yelinz Yelinz marked this pull request as ready for review November 15, 2024 15:23
@Yelinz Yelinz requested a review from derrabauke November 15, 2024 15:23
derrabauke
derrabauke approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

Only one tiny nit pick but that's optional and up to your taste.

ember/app/ui/components/case-transfer/template.hbs Outdated Show resolved Hide resolved
@Yelinz Yelinz merged commit 4bc39d0 into adfinis:main Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabauke derrabauke derrabauke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yelinz @derrabauke