Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(timed): update frontend image tag to v3.2.0 #1075

Merged
merged 1 commit into from
Aug 2, 2023
Merged

chore(timed): update frontend image tag to v3.2.0 #1075

merged 1 commit into from
Aug 2, 2023

Conversation

derrabauke
Copy link
Contributor

Description

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@derrabauke derrabauke requested a review from a team as a code owner July 28, 2023 13:57
@derrabauke derrabauke self-assigned this Jul 28, 2023
@derrabauke derrabauke requested a review from a team as a code owner July 28, 2023 13:57
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2023
@derrabauke derrabauke force-pushed the chore-timed-frontend-upgrade-3.2.0 branch from 6c0b83b to 9533359 Compare July 28, 2023 14:00
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2023
hairmare
hairmare approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic 👀 😍

@derrabauke
Copy link
Contributor Author

derrabauke commented Jul 28, 2023 •
edited
Loading

magic 👀 😍

YES! ✨

@hairmare you can help me with the failing tests?

Error from server (BadRequest): container "timed-frontend" in pod "timed-2mcvt7z5hk-frontend-5c6b789656-8k6wq" is waiting to start: trying and failing to pull image

🤔

@derrabauke
Copy link
Contributor Author

Ahh got it myself... building the container failed

@hairmare
Copy link
Contributor

@hairmare you can help me with the failing tests?

failed to pull and unpack image "ghcr.io/adfinis/timed-frontend:v3.2.0": failed to resolve reference "ghcr.io/adfinis/timed-frontend:v3.2.0": ghcr.io/adfinis/timed-frontend:v3.2.0: not found

do we need to wait on ci and then rerun?

@derrabauke derrabauke force-pushed the chore-timed-frontend-upgrade-3.2.0 branch from 9533359 to 4726fb0 Compare August 2, 2023 08:53
hairmare
hairmare approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@derrabauke derrabauke merged commit 2650a0e into adfinis:main Aug 2, 2023
3 checks passed
@derrabauke derrabauke deleted the chore-timed-frontend-upgrade-3.2.0 branch August 2, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare approved these changes

@janaurka janaurka Awaiting requested review from janaurka janaurka is a code owner automatically assigned from adfinis/helm-charts

@isantospardo isantospardo Awaiting requested review from isantospardo isantospardo is a code owner automatically assigned from adfinis/helm-charts

Assignees

@derrabauke derrabauke

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabauke @hairmare