Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reachability dependency #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HenriBeck
Copy link

I'm not quite sure why Reachability was a dependency but removing it didn't cause any issues for me.

@MisterJimson
Copy link

This is causing issues for me as other libs depend on ReachabilitySwift and during release builds linking can fail with conflicts.

@HenriBeck
Copy link
Author

@MisterJimson

For now, you could use this:

  keyboard_visibility:
    git:
      url: https://github.com/HenriBeck/flutter_keyboard_visibility.git
      ref: 1f87a4b7797df567f63a3248ee7ed7aa0179f35b

@MisterJimson
Copy link

Hey I would really like to see this merged. While we can use a forked version, that does not work well for other packages that depend on this lib. Let me know if there is anything I can do to help.

@mixdesign
Copy link

@adee42 Would you review the suggested merge request? Thank you

@MisterJimson
Copy link

FYI I pulled this bug fix into my fork if you want to use it: https://github.com/MisterJimson/flutter_keyboard_visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants