README.md + deprecated FakeConnectionFactory.UseBackgroundThreadsForI…

…O (due to upstream deprecation)
addupsolutions · Oct 16, 2023 · 851e459 · 851e459
1 parent c5df9bd
commit 851e459
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -38,13 +38,18 @@ Thanks to all the contributors:
 * [@inbarbarkai](https://github.com/inbarbarkai)
 * [@Quogu](https://github.com/Quogu)
 * [@patrikwlund](https://github.com/patrikwlund)
+* [@marcusber](https://github.com/marcusber)
 
 ## History
 
 > Versions 1.x are based on [RabbitMQ .NET client Version 5.x](https://www.nuget.org/packages/RabbitMQ.Client/5.2.0)
 >
 > Versions 2.x are based on [RabbitMQ .NET client Version 6.x](https://www.nuget.org/packages/RabbitMQ.Client/6.2.4)
 
+### [Version 2.7.0 - 2023/10/16](https://github.com/addupsolutions/AddUp.FakeRabbitMQ/releases/tag/v2.7.0)
+
+* Updated **RabbitMQ.Client** to version [6.6.0](https://github.com/rabbitmq/rabbitmq-dotnet-client/releases/tag/v6.6.0) thanks to [@marcusber](https://github.com/marcusber)'s [PR #174](https://github.com/addupsolutions/AddUp.FakeRabbitMQ/pull/174)
+
 ### [Version 2.6.0 - 2023/03/29](https://github.com/addupsolutions/AddUp.FakeRabbitMQ/releases/tag/v2.6.0)
 
 * Updated **RabbitMQ.Client** to version [6.5.0](https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/CHANGELOG.md#v650-2023-03-24)

diff --git a/src/AddUp.FakeRabbitMQ.Tests/FakeConnectionFactoryTests.cs b/src/AddUp.FakeRabbitMQ.Tests/FakeConnectionFactoryTests.cs
@@ -73,7 +73,6 @@ public void Properties_retain_their_values_when_set()
                 RequestedChannelMax = 1,
                 RequestedFrameMax = 1u,
                 RequestedHeartbeat = TimeSpan.FromSeconds(1.0),
-                UseBackgroundThreadsForIO = true,
                 UserName = "johndoe",
                 VirtualHost = "host",
                 Uri = new Uri("http://foo.bar.baz/"),
@@ -86,7 +85,6 @@ public void Properties_retain_their_values_when_set()
             Assert.Equal((ushort)1, factory.RequestedChannelMax);
             Assert.Equal(1u, factory.RequestedFrameMax);
             Assert.Equal(1.0, factory.RequestedHeartbeat.TotalSeconds);
-            Assert.True(factory.UseBackgroundThreadsForIO);
             Assert.Equal("johndoe", factory.UserName);
             Assert.Equal("host", factory.VirtualHost);
             Assert.Equal("http://foo.bar.baz/", factory.Uri.ToString());

diff --git a/src/AddUp.FakeRabbitMQ/FakeConnectionFactory.cs b/src/AddUp.FakeRabbitMQ/FakeConnectionFactory.cs
@@ -19,6 +19,7 @@ public FakeConnectionFactory(RabbitServer rabbitServer) =>
         public ushort RequestedChannelMax { get; set; }
         public uint RequestedFrameMax { get; set; }
         public TimeSpan RequestedHeartbeat { get; set; }
+        [Obsolete("Currently a no-op. UseBackgroundThreadsForIO will be removed in version 7")] // See https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1388
         public bool UseBackgroundThreadsForIO { get; set; }
         public string UserName { get; set; }
         public string VirtualHost { get; set; }

diff --git a/src/AddUp.FakeRabbitMQ/GlobalSuppressions.cs b/src/AddUp.FakeRabbitMQ/GlobalSuppressions.cs
@@ -10,3 +10,4 @@
 [assembly: SuppressMessage("Major Code Smell", "S4144:Methods should not have identical implementations", Justification = "<Pending>", Scope = "member", Target = "~M:AddUp.RabbitMQ.Fakes.FakeModel.Abort(System.UInt16,System.String)")]
 [assembly: SuppressMessage("Minor Code Smell", "S1116:Empty statements should be removed", Justification = "<Pending>", Scope = "member", Target = "~M:AddUp.RabbitMQ.Fakes.RabbitQueue.ClearMessages")]
 [assembly: SuppressMessage("Style", "IDE0032:Use auto property", Justification = "<Pending>", Scope = "member", Target = "~F:AddUp.RabbitMQ.Fakes.FakeModel.workingMessages")]
+[assembly: SuppressMessage("Info Code Smell", "S1133:Deprecated code should be removed", Justification = "<Pending>", Scope = "member", Target = "~P:AddUp.RabbitMQ.Fakes.FakeConnectionFactory.UseBackgroundThreadsForIO")]