Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yf optional quote input #30

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yfarjoun
Copy link

this PR allows the user to control whether the input to the "script" will be wrapped in quotes (default) or not.

By specifying 'false' one can then run arbitrary docker images that require various inputs (for this one would also need to disable various other contols:

 script_prefix: ""
 shell: ""
 quote_argument: false

Yossi Farjoun and others added 5 commits April 14, 2021 23:06
author Yossi Farjoun <[email protected]> 1617479686 -0400
committer Yossi Farjoun <[email protected]> 1618455120 -0400

Change the way the script is run. instead of modfying the ENTRYPOINT, we will simply add the "shell" (default sh) and the "script_prefix" (default -c)
and then the script.

That way the possible comple entry point is not disturbed. if a user would like to remove the ENTRYPOINT they can provide an "option" "--entrypoint ''" for example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant