Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/scala3 #123

Merged
merged 50 commits into from
Mar 4, 2025
Merged

feat/scala3 #123

merged 50 commits into from
Mar 4, 2025

Conversation

adarro
Copy link
Owner

@adarro adarro commented Mar 4, 2025

update codebase to Scala 3, Kotlin 2.x, Java 21+, Gradle 8.13
FIX: conflicting scala3 / scala2 dependencies
FIX: spotless / trunk task dependency failures and synchronization
FIX: Check task runs Quarkus, Junit5, Scalatest
Upgrade: Junit5
CHORE: Remove some dead / obsolete code.
CHORE: 90% migration to Gradle Version Catalogs

Hopefully last major mass format needed for a while.

adarro added 30 commits August 15, 2024 19:50
🎨Format
🚧 Introduced DAL
📌 bumped Kotlin to 2.0
:wip: Dal has example Rest Bean Resource still
…ntellisense and have properly placed package generation.

🚧 fleshing out Feature / categories and internal effect creation / parsing.
🚧 Add ExtraTurning and ImprovedTurning Feats
✏️ Some comment / build file clean up
:Widened Item to support Potions, scrolls.
Introduced PermanentItem and CommonItem traits
TODO: will need to move entities to DAL and switch Active Record to Repository Pattern to support both Sync / Async wrappers (Mutiny) for Service vs Renarde Templates.
compile against x-source3-cross
update LevelCap
Initial Vile Chemist Core Enhancements
add some memory checks
add scalafix (config TBD)
…ggeredActivatationImpl and applied to general feat for initialization. Need to do for the rest of the feats. (ClassFeat etc.)
Added BonusSelectableToClassFeatImpl and TriggeredActivatationImpl
scala3 -rewrite with all basic tests once again passing locally
linting ip
linting phase 333, many line breaks seems to change to CRLF unneeded?
trunk / scalafmt
trunk / scalafmt
:construction: clean quarkus component / jandex
:construction: Add ScalingEffect
:construction: add ZIO validation for DetailedEffect (BonusType, Triggers, Scaling)
:construction: wip removing package objects
trunk / scalafmt
:construction: clean quarkus component / jandex
:construction: Add ScalingEffect
:construction: add ZIO validation for DetailedEffect (BonusType, Triggers, Scaling)
:construction: wip removing package objects
🚧Scala3 Quarkus
Add / remove bloop
🎨 improve trunk fmt lint
🚧 Add some DAL persistence scaffolding
Renarde must directly use panacheEntity (non-reactive) so we need to split entities still.
🚧 include taxi into avro scala composite / included build, scala3 poc (temporary)
🚧 include taxi into avro scala composite / included build, scala3 poc (temporary)
🚧 clean version catalog
🚧 clean version catalog

Add errorprone / nullaway /jspecify
for Java adjacent projects
Add google truth assertions for test
🚧 clean version catalog

Migrate scalatest (propertychecks) to newer (tabledrivenpropertychecks) trait.
FIXED: semanticdb files litering source tree
🚧 sync trunk / spotless

spotless and trunk now both use ktlint.
Formatting should generally be enforced on new / editing code in java / scala / kotlin.
SNAPSHOT

Configuring catalog version plugins
attempting to re-fix spotless (implicit /
explicit dependencies)
SNAPSHOT

Gradle -> 8.13 (TestSuiteType deprecated)
scala -> 3.6.3
SNAPSHOT

spotless re-included as common include.
added explicit dependency attachment
to java-based projects.
SNAPSHOT

Hopefully fixed new line / line endings
Need a serious minor warning / issue pass.

misc - included basic just file.
CHORE: bump circle ci workflow to Java 21
CHORE: Debug possible CI build failing due to
insufficient clone depth. (spotless rachet from)

@see diffplug/spotless#1902
FIX: Scoverage aggregateReport task no long appears.
FIX: Must use a positive number (can't fetch depth 0)
FIX: Removing task from github actions for later debug
FIX: Removing task from github actions for later debug
FIX: add orphaned class file.
FIX: add orphaned class file.
Read / Write / Error objects
@adarro adarro merged commit cf0adfa into master Mar 4, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant