Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#381 Vanilla Theme Picker Optimisation #404

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

#381 Vanilla Theme Picker Optimisation #404

wants to merge 13 commits into from

Conversation

zubairslamdien
Copy link

Updates #381

Update

  • Updated theme.schema.json to support new font and custom CSS/Less AAT theme picker settings.

zubairslamdien and others added 11 commits January 20, 2023 13:16
@zubairslamdien
Update theme.schema.json
570d5f7 
schema change for font uploads
@zubairslamdien
Updated theme schema for font family as array
99eb3ae
@zubairslamdien
font files moved into an object in schema
a46cfa8
@zubairslamdien
Theme by config
16202ac 
Heading text changed, sections rearranged and weight properties now use dropdowns and italics instruction text checkbox added.
@zubairslamdien
Merge branch 'adaptlearning:master' into master
f17709e
@zubairslamdien
theme.schema.json updated
74882d6 
File upload order changed.
More family and weight properties added.
External Font array added
@zubairslamdien
Merge branch 'adaptlearning:master' into master
4f403fb
@zubairslamdien
Merge branch 'adaptlearning:master' into master
90022fb
@taylortom
Update theme.schema.json
19a2915
@zubairslamdien
Merge branch 'adaptlearning:master' into master
484724f
@zubairslamdien
Theme by config schema changes
031d9a4 
-Font file order changed
-Default values added for all font fields
-Subtitle section removed
-Link font family removed
-Custom CSS/Less editor textbox added
@zubairslamdien zubairslamdien mentioned this pull request Mar 16, 2023
Closed
1 task
taylortom
taylortom requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there's no planned support for these extra theme settings in the legacy AAT, we should forget adding the settings to the old properties schema

@zubairslamdien
Copy link
Author

I've removed the schema changes from the legacy file.

@taylortom taylortom mentioned this pull request Apr 5, 2023
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@StuartNicholls StuartNicholls StuartNicholls approved these changes

@taylortom taylortom taylortom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zubairslamdien @taylortom @StuartNicholls @cahirodoherty-learningpool