Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets) Add VerticalSizePartitioner #4699

Merged
merged 18 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions datasets/flwr_datasets/partitioner/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from .shard_partitioner import ShardPartitioner
from .size_partitioner import SizePartitioner
from .square_partitioner import SquarePartitioner
from .vertical_size_partitioner import VerticalSizePartitioner

__all__ = [
"DirichletPartitioner",
Expand All @@ -45,4 +46,5 @@
"ShardPartitioner",
"SizePartitioner",
"SquarePartitioner",
"VerticalSizePartitioner",
]
103 changes: 103 additions & 0 deletions datasets/flwr_datasets/partitioner/vertical_partitioner_utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
# Copyright 2024 Flower Labs GmbH. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ==============================================================================
"""VerticalPartitioner utils.py."""
# flake8: noqa: E501
# pylint: disable=C0301
from typing import Any, Literal, Union


def _list_split(lst: list[Any], num_sublists: int) -> list[list[Any]]:
"""Split a list into n nearly equal-sized sublists.

Parameters
----------
lst : list[Any]
The list to split.
num_sublists : int
Number of sublists to create.

Returns
-------
subslist: list[list[Any]]
A list containing num_sublists sublists.
"""
if num_sublists <= 0:
raise ValueError("Number of splits must be greater than 0")
chunk_size, remainder = divmod(len(lst), num_sublists)
sublists = []
start_index = 0
for i in range(num_sublists):
end_index = start_index + chunk_size
if i < remainder:
end_index += 1
sublists.append(lst[start_index:end_index])
start_index = end_index
return sublists


def _add_active_party_columns(
active_party_columns: list[str],
active_party_columns_mode: Union[
Literal[
"add_to_first",
"add_to_last",
"create_as_first",
"create_as_last",
"add_to_all",
],
int,
],
partition_columns: list[list[str]],
) -> list[list[str]]:
"""Add active party columns to the partition columns based on the mode.

Parameters
----------
active_party_columns : list[str]
List of active party columns.
active_party_columns_mode : Union[Literal["add_to_first", "add_to_last", "create_as_first", "create_as_last", "add_to_all"], int]
Mode to add active party columns to partition columns.

Returns
-------
partition_columns: list[list[str]]
List of partition columns after the modyfication.
"""
if isinstance(active_party_columns_mode, int):
partition_id = active_party_columns_mode
if partition_id < 0 or partition_id >= len(partition_columns):
raise ValueError(
f"Invalid partition index {partition_id} for active_party_columns_mode."
f"Must be in the range [0, {len(partition_columns) - 1}]"
f"but given {partition_id}"
)
for column in active_party_columns:
partition_columns[partition_id].append(column)
else:
if active_party_columns_mode == "add_to_first":
for column in active_party_columns:
partition_columns[0].append(column)
elif active_party_columns_mode == "add_to_last":
for column in active_party_columns:
partition_columns[-1].append(column)
elif active_party_columns_mode == "create_as_first":
partition_columns.insert(0, active_party_columns)
elif active_party_columns_mode == "create_as_last":
partition_columns.append(active_party_columns)
elif active_party_columns_mode == "add_to_all":
for column in active_party_columns:
for partition in partition_columns:
partition.append(column)
return partition_columns
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
# Copyright 2024 Flower Labs GmbH. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ==============================================================================
"""Tests for vertical partitioner utilities."""
import unittest
from typing import Any, Literal

from flwr_datasets.partitioner.vertical_partitioner_utils import (
_add_active_party_columns,
_list_split,
)


class TestVerticalPartitionerUtils(unittest.TestCase):
"""Tests for _list_split and _add_active_party_columns utilities."""

def test_list_split_basic_splitting(self) -> None:
"""Check equal splitting with divisible lengths."""
lst = [1, 2, 3, 4, 5, 6]
result = _list_split(lst, 3)
expected = [[1, 2], [3, 4], [5, 6]]
self.assertEqual(result, expected)

def test_list_split_uneven_splitting(self) -> None:
"""Check uneven splitting with non-divisible lengths."""
lst = [10, 20, 30, 40, 50]
result = _list_split(lst, 2)
expected = [[10, 20, 30], [40, 50]]
self.assertEqual(result, expected)

def test_list_split_single_sublist(self) -> None:
"""Check that single sublist returns the full list."""
lst = [1, 2, 3]
result = _list_split(lst, 1)
expected = [[1, 2, 3]]
self.assertEqual(result, expected)

def test_list_split_more_sublists_than_elements(self) -> None:
"""Check extra sublists are empty when count exceeds length."""
lst = [42]
result = _list_split(lst, 3)
expected = [[42], [], []]
self.assertEqual(result, expected)

def test_list_split_empty_list(self) -> None:
"""Check splitting empty list produces empty sublists."""
lst: list[Any] = []
result = _list_split(lst, 3)
expected: list[list[Any]] = [[], [], []]
self.assertEqual(result, expected)

def test_list_split_invalid_num_sublists(self) -> None:
"""Check ValueError when sublist count is zero or negative."""
lst = [1, 2, 3]
with self.assertRaises(ValueError):
_list_split(lst, 0)

def test_add_to_first(self) -> None:
"""Check adding active cols to the first partition."""
partition_columns = [["col1", "col2"], ["col3"], ["col4"]]
active_party_columns = ["active1", "active2"]
mode: Literal["add_to_first"] = "add_to_first"
result = _add_active_party_columns(
active_party_columns, mode, partition_columns
)
self.assertEqual(
result, [["col1", "col2", "active1", "active2"], ["col3"], ["col4"]]
)

def test_add_to_last(self) -> None:
"""Check adding active cols to the last partition."""
partition_columns = [["col1", "col2"], ["col3"], ["col4"]]
active_party_columns = ["active"]
mode: Literal["add_to_last"] = "add_to_last"
result = _add_active_party_columns(
active_party_columns, mode, partition_columns
)
self.assertEqual(result, [["col1", "col2"], ["col3"], ["col4", "active"]])

def test_create_as_first(self) -> None:
"""Check creating a new first partition for active cols."""
partition_columns = [["col1"], ["col2"]]
active_party_columns = ["active1", "active2"]
mode: Literal["create_as_first"] = "create_as_first"
result = _add_active_party_columns(
active_party_columns, mode, partition_columns
)
self.assertEqual(result, [["active1", "active2"], ["col1"], ["col2"]])

def test_create_as_last(self) -> None:
"""Check creating a new last partition for active cols."""
partition_columns = [["col1"], ["col2"]]
active_party_columns = ["active1", "active2"]
mode: Literal["create_as_last"] = "create_as_last"
result = _add_active_party_columns(
active_party_columns, mode, partition_columns
)
self.assertEqual(result, [["col1"], ["col2"], ["active1", "active2"]])

def test_add_to_all(self) -> None:
"""Check adding active cols to all partitions."""
partition_columns = [["col1"], ["col2", "col3"], ["col4"]]
active_party_columns = ["active"]
mode: Literal["add_to_all"] = "add_to_all"
result = _add_active_party_columns(
active_party_columns, mode, partition_columns
)
self.assertEqual(
result, [["col1", "active"], ["col2", "col3", "active"], ["col4", "active"]]
)

def test_add_to_specific_partition_valid_index(self) -> None:
"""Check adding active cols to a specific valid partition."""
partition_columns = [["col1"], ["col2"], ["col3"]]
active_party_columns = ["active1", "active2"]
mode: int = 1
result = _add_active_party_columns(
active_party_columns, mode, partition_columns
)
self.assertEqual(result, [["col1"], ["col2", "active1", "active2"], ["col3"]])

def test_add_to_specific_partition_invalid_index(self) -> None:
"""Check ValueError when partition index is invalid."""
partition_columns = [["col1"], ["col2"]]
active_party_columns = ["active"]
mode: int = 5
with self.assertRaises(ValueError) as context:
_add_active_party_columns(active_party_columns, mode, partition_columns)
self.assertIn("Invalid partition index", str(context.exception))


if __name__ == "__main__":
unittest.main()
Loading