Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework) Improve import management in load_app function in object_ref.py #4452

Merged
merged 6 commits into from
Nov 7, 2024
Merged

fix(framework) Improve import management in load_app function in object_ref.py #4452

merged 6 commits into from
Nov 7, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Nov 7, 2024 •
edited
Loading

A big bug in the previous version: the loaded modules won't be unloaded if load_app is called again.

@danieljanes danieljanes merged commit a633334 into main Nov 7, 2024
52 of 53 checks passed
@danieljanes danieljanes deleted the improve-loadapp-import-mgmt branch November 7, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @jafermarq