New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add first implementation of `NodeState` #4439

Merged

danieljanes merged 27 commits into main from feat/add-nodestate

Nov 7, 2024

Contributor

chongshenng commented Nov 6, 2024

Introduce NodeState ABC with set/get_node_id()
Introduce InMemoryNodeState and basic test
Introduce NodeStateFactory
Add usage of state.set_node_id() in SuperNode

chongshenng added 5 commits

November 4, 2024 20:26


          Init

3ca2861


          Init tests

f94d484


          Add basic set and get


          Merge branch 'main' into feat/add-nodestate

aae8794


          Add copyright

32a666b

chongshenng marked this pull request as ready for review

November 6, 2024 10:35

chongshenng requested review from danieljanes and tanertopal as code owners

November 6, 2024 10:35

chongshenng requested a review from panh99

November 6, 2024 10:35

chongshenng self-assigned this

chongshenng added 5 commits

November 6, 2024 10:40


          Lint

7599c28

Fix

9f1620b


          Remove

5c38ece


          Fix circular import

e7c7520


          Assign node_id before reference

a39f075

panh99 reviewed

View reviewed changes

src/py/flwr/client/supernode/nodestate/in_memory_nodestate.py Outdated Show resolved Hide resolved

chongshenng added 2 commits

November 6, 2024 12:17


          Only save node_id

9c0f2d5


          Fix type

b9bf5bf

panh99 previously approved these changes

View reviewed changes

Contributor

panh99 left a comment

LGTM!


          Merge branch 'main' into feat/add-nodestate

ef39844

danieljanes reviewed

View reviewed changes

src/py/flwr/client/supernode/nodestate/in_memory_nodestate.py Outdated Show resolved Hide resolved


          Update src/py/flwr/client/supernode/nodestate/in_memory_nodestate.py

f3e65a4

danieljanes dismissed panh99’s stale review via

f3e65a4

November 6, 2024 13:11

danieljanes reviewed

View reviewed changes

src/py/flwr/client/supernode/nodestate/in_memory_nodestate.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/client/supernode/nodestate/nodestate_factory.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/client/app.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/client/supernode/app.py Outdated Show resolved Hide resolved


          Address comments

108b98d

danieljanes reviewed

View reviewed changes

src/py/flwr/client/supernode/nodestate/in_memory_nodestate.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/client/app.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/client/app.py Outdated Show resolved Hide resolved

chongshenng added 6 commits

November 6, 2024 22:05


          Address changes

050820f


          Merge branch 'main' into feat/add-nodestate

6fbc2a6


          Fix circular import

d497fd5


          Merge branch 'main' into feat/add-nodestate

1f5a997


          Fix import in test

76aa3d8


          Fix create_node()

79632a4

danieljanes reviewed

View reviewed changes

src/py/flwr/client/app.py Outdated Show resolved Hide resolved


          Update src/py/flwr/client/app.py

6d46177

danieljanes reviewed

View reviewed changes

src/py/flwr/client/nodestate/in_memory_nodestate.py Outdated Show resolved Hide resolved


          Update src/py/flwr/client/nodestate/in_memory_nodestate.py

69053ec

danieljanes previously approved these changes

View reviewed changes


          Merge branch 'main' into feat/add-nodestate

53e76d3

danieljanes enabled auto-merge (squash)

November 7, 2024 14:59


          Apply black format

1fbf1de

chongshenng dismissed danieljanes’s stale review via

1fbf1de

November 7, 2024 15:04


          Add test for get_node_id

070aa1f

danieljanes approved these changes

View reviewed changes


          Merge branch 'main' into feat/add-nodestate

ebaeaa6

danieljanes merged commit 8cb84a4 into main

53 checks passed

danieljanes deleted the feat/add-nodestate branch

November 7, 2024 16:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet