Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Upgrade Ubuntu base image to version 24.04 #4226

Merged
merged 2 commits into from
Sep 24, 2024
Merged

feat(framework) Upgrade Ubuntu base image to version 24.04 #4226

merged 2 commits into from
Sep 24, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Sep 17, 2024 •
edited
Loading

Issue

Description

  • Upgraded the Ubuntu base image to version 24.04.
  • Tested the new Ubuntu 24.04 image on our quickstart examples (quickstart-fastai, quickstart-huggingface, quickstart-monai, quickstart-pandas, quickstart-pytorch, quickstart-sklearn-tabular) and verified the functionality of the docker compose quickstart guide, which includes TLS and SuperLink state.
  • A test run of the changes can be reviewed here: Test CI build run
  • Updated the Ubuntu version in the Docker docs.
  • Ubuntu 24.04 does not contain adduser anymore but adduser is just a wrapper of useradd.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner Robert-Steiner self-assigned this Sep 17, 2024
@Robert-Steiner Robert-Steiner changed the title feat(framework) Upgrade Ubuntu base image to version 24.10 feat(framework) Upgrade Ubuntu base image to version 24.04 Sep 17, 2024
@Robert-Steiner Robert-Steiner force-pushed the feat/update-ubuntu-24 branch 3 times, most recently from d89ca6d to 7380c17 Compare September 23, 2024 16:02
@Robert-Steiner Robert-Steiner marked this pull request as ready for review September 23, 2024 16:22
@tanertopal tanertopal enabled auto-merge (squash) September 24, 2024 10:37
tanertopal
tanertopal approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanertopal tanertopal merged commit b911d8d into main Sep 24, 2024
32 checks passed
@tanertopal tanertopal deleted the feat/update-ubuntu-24 branch September 24, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@Moep90 Moep90 Moep90 approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees

@Robert-Steiner Robert-Steiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robert-Steiner @tanertopal @Moep90