Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(framework:skip) Refactor SuperExec e2e test #4225

Merged
merged 39 commits into from
Sep 27, 2024
Merged

ci(framework:skip) Refactor SuperExec e2e test #4225

merged 39 commits into from
Sep 27, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Sep 17, 2024 •
edited
Loading

Issue

Depends on

Description

Related issues/PRs

Proposal

Will close/deprecate #4030 in favour of this PR.

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@chongshenng
Init
2cf4dc5
@chongshenng
Init
c3569a1
@chongshenng
Init change to e2e
17d9d37
@chongshenng
Change permissions, update name in CI
afbd947
@chongshenng
Change double quotes to single quotes to preserve literal values
8e2429b
@chongshenng
Add optional extras when installing wheel from artifact store
a55de8c
@chongshenng
Modify installation from Flower wheel
77284b3
@chongshenng
Conform to pypi wheel name convention
b4cf87e
@chongshenng
Refactor CI
6f132a5
@chongshenng
Change to no-auth
61be6b9
@chongshenng
Small fixes
4a78dd7
@chongshenng
Remove flwr from pyproject.toml
d369ead
@chongshenng
Add new line
27bb83c
@chongshenng
Test yaml concat
71957a7
@chongshenng
Add Python matrix
5a721b7
@chongshenng
Minor fixes
6d623b6
@chongshenng
Tweaks
4ba33a4
@chongshenng
Fix
e247de0
@chongshenng
Merge branch 'main' into refactor-superexec-e2e-test
dadc572
@chongshenng
Update name
3323c79
@chongshenng
Skip node_id check for GetFabRequest
2d4ed8b
@chongshenng
Add auth check
752d31c
@chongshenng
Intermediate
58172e7
@chongshenng
Fix matrix strategy
7f3b5a9
@chongshenng
Expand e2e
0456652
@chongshenng
Full e2e
9401cc6
@chongshenng
Merge branch 'main' into refactor-superexec-e2e-test
bdf5228
@chongshenng
Merge branch 'main' into refactor-superexec-e2e-test
274ad93
Robert-Steiner
Robert-Steiner reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow looks good to me. I just added two suggestions nothing major.

@chongshenng chongshenng marked this pull request as ready for review September 27, 2024 11:16
@danieljanes danieljanes enabled auto-merge (squash) September 27, 2024 18:38
@danieljanes danieljanes merged commit 86b75f0 into main Sep 27, 2024
49 of 50 checks passed
@danieljanes danieljanes deleted the refactor-superexec-e2e-test branch September 27, 2024 18:44
@chongshenng chongshenng mentioned this pull request Nov 5, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robert-Steiner Robert-Steiner Robert-Steiner left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chongshenng @danieljanes @Robert-Steiner @panh99