feat(framework:skip) Add cronjob to periodically build Docker image of latest flwr release #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Steiner <[email protected]>
Robert-Steiner
force-pushed
the
feat/cron-job-rebuild-latest-image
branch
from
f0de317 to
967790f
Compare
Signed-off-by: Robert Steiner <[email protected]>
Signed-off-by: Robert Steiner <[email protected]>
Signed-off-by: Robert Steiner <[email protected]>
Robert-Steiner
force-pushed
the
feat/cron-job-rebuild-latest-image
branch
from
5627b8d to
25797eb
Compare
Robert-Steiner
requested review from
tanertopal and
danieljanes
as code owners
tanertopal
reviewed
Sep 10, 2024
.github/workflows/docker-cronjob.yml
Outdated
|
|
||
| - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | ||
| with: | ||
| # ref: v${{ steps.flwr-version.outputs.flwr-version }} |
There was a problem hiding this comment.
Isn't this line a duplicate of the next?
There was a problem hiding this comment.
good catch! i removed it
tanertopal
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
@Robert-Steiner
@danieljanes and I just discussed that, technically, we don't have an automated testing pipeline for the Docker artifacts the same way we thoroughly test the Flower library build artifacts. We will postpone merging this to avoid accidentally breaking Docker images until we have an E2E test for the images.
danieljanes
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?