ci(framework:skip) Update PyLint to 3.3.1

pyproject.toml

@@ -95,7 +95,7 @@ black = { version = "==24.2.0", extras = ["jupyter"] }
 taplo = "==0.9.3"
 docformatter = "==1.7.5"
 mypy = "==1.8.0"
-pylint = "==3.0.3"
+pylint = "==3.2.7"
 flake8 = "==5.0.4"
 parameterized = "==0.9.0"
 pytest = "==7.4.4"

src/py/flwr/client/clientapp/app.py

@@ -132,11 +132,10 @@ def run_clientapp(  # pylint: disable=R0914
             )
 
             try:
-                if fab:
-                    # Load ClientApp
-                    client_app: ClientApp = load_client_app_fn(
-                        run.fab_id, run.fab_version, fab.hash_str
-                    )
+                # Load ClientApp
+                client_app: ClientApp = load_client_app_fn(
+                    run.fab_id, run.fab_version, fab.hash_str if fab else ""
+                )
 
                 # Execute ClientApp
                 reply_message = client_app(message=message, context=context)

src/py/flwr/common/record/configsrecord.py

@@ -128,6 +128,7 @@ def count_bytes(self) -> int:
 
         def get_var_bytes(value: ConfigsScalar) -> int:
             """Return Bytes of value passed."""
+            var_bytes = 0
             if isinstance(value, bool):
                 var_bytes = 1
             elif isinstance(value, (int, float)):
@@ -136,6 +137,11 @@ def get_var_bytes(value: ConfigsScalar) -> int:
                 )
             if isinstance(value, (str, bytes)):
                 var_bytes = len(value)
+            if var_bytes == 0:
+                raise ValueError(
+                    "Config values must be either `bool`, `int`, `float`, "
+                    "`str`, or `bytes`"
+                )
             return var_bytes
 
         num_bytes = 0

src/py/flwr/server/compat/driver_client_proxy_test.py

@@ -237,9 +237,9 @@ def _exec_send_and_receive(
 
         def generate_replies(messages: Iterable[Message]) -> Iterable[Message]:
             msg = list(messages)[0]
+            recordset = None
             if error_reply:
-                recordset = None
-                ret = msg.create_error_reply(ERROR_REPLY)
+                pass
             elif isinstance(res, GetParametersRes):
                 recordset = compat.getparametersres_to_recordset(res, True)
             elif isinstance(res, GetPropertiesRes):
@@ -248,10 +248,11 @@ def generate_replies(messages: Iterable[Message]) -> Iterable[Message]:
                 recordset = compat.fitres_to_recordset(res, True)
             elif isinstance(res, EvaluateRes):
                 recordset = compat.evaluateres_to_recordset(res)
-            else:
-                raise ValueError(f"Unsupported type: {type(res)}")
+
             if recordset is not None:
                 ret = msg.create_reply(recordset)
+            else:
+                ret = msg.create_error_reply(ERROR_REPLY)
 
             # Reply messages given the push message
             return [ret]

src/py/flwr/server/strategy/bulyan_test.py

@@ -124,7 +124,7 @@ def test_aggregate_fit() -> None:
     actual_aggregated, _ = strategy.aggregate_fit(
         server_round=1, results=results, failures=[]
     )
-    if actual_aggregated:
-        actual_list = parameters_to_ndarrays(actual_aggregated)
-        actual = actual_list[0]
+    assert actual_aggregated
+    actual_list = parameters_to_ndarrays(actual_aggregated)
+    actual = actual_list[0]
     assert (actual == expected[0]).all()

src/py/flwr/server/strategy/fedadagrad_test.py

@@ -79,7 +79,7 @@ def test_aggregate_fit() -> None:
     actual_aggregated, _ = strategy.aggregate_fit(
         server_round=1, results=results, failures=[]
     )
-    if actual_aggregated:
-        actual_list = parameters_to_ndarrays(actual_aggregated)
-        actual = actual_list[0]
+    assert actual_aggregated
+    actual_list = parameters_to_ndarrays(actual_aggregated)
+    actual = actual_list[0]
     assert (actual == expected[0]).all()

src/py/flwr/server/strategy/fedmedian_test.py

@@ -193,7 +193,7 @@ def test_aggregate_fit() -> None:
     actual_aggregated, _ = strategy.aggregate_fit(
         server_round=1, results=results, failures=[]
     )
-    if actual_aggregated:
-        actual_list = parameters_to_ndarrays(actual_aggregated)
-        actual = actual_list[0]
+    assert actual_aggregated
+    actual_list = parameters_to_ndarrays(actual_aggregated)
+    actual = actual_list[0]
     assert (actual == expected[0]).all()

src/py/flwr/server/strategy/krum_test.py

@@ -194,7 +194,7 @@ def test_aggregate_fit() -> None:
     actual_aggregated, _ = strategy.aggregate_fit(
         server_round=1, results=results, failures=[]
     )
-    if actual_aggregated:
-        actual_list = parameters_to_ndarrays(actual_aggregated)
-        actual = actual_list[0]
+    assert actual_aggregated
+    actual_list = parameters_to_ndarrays(actual_aggregated)
+    actual = actual_list[0]
     assert (actual == expected[0]).all()

src/py/flwr/server/strategy/multikrum_test.py

@@ -93,7 +93,7 @@ def test_aggregate_fit() -> None:
     actual_aggregated, _ = strategy.aggregate_fit(
         server_round=1, results=results, failures=[]
     )
-    if actual_aggregated:
-        actual_list = parameters_to_ndarrays(actual_aggregated)
-        actual = actual_list[0]
+    assert actual_aggregated
+    actual_list = parameters_to_ndarrays(actual_aggregated)
+    actual = actual_list[0]
     assert (actual == expected[0]).all()

src/py/flwr/server/superlink/fleet/vce/vce_api.py

@@ -267,6 +267,8 @@ def start_vce(
     existing_nodes_mapping: Optional[NodeToPartitionMapping] = None,
 ) -> None:
     """Start Fleet API with the Simulation Engine."""
+    nodes_mapping = {}
+
     if client_app_attr is not None and client_app is not None:
         raise ValueError(
             "Both `client_app_attr` and `client_app` are provided, "
@@ -340,17 +342,17 @@ def backend_fn() -> Backend:
     # Load ClientApp if needed
     def _load() -> ClientApp:
 
+        if client_app:
+            return client_app
         if client_app_attr:
-            app = get_load_client_app_fn(
+            return get_load_client_app_fn(
                 default_app_ref=client_app_attr,
                 app_path=app_dir,
                 flwr_dir=flwr_dir,
                 multi_app=False,
             )(run.fab_id, run.fab_version, run.fab_hash)
 
-        if client_app:
-            app = client_app
-        return app
+        raise ValueError("Either `client_app_attr` or `client_app` must be provided")
 
     app_fn = _load
 

src/py/flwr/server/superlink/state/state_test.py

@@ -316,8 +316,8 @@ def test_task_res_store_and_retrieve_by_task_ins_id(self) -> None:
         # Execute
         task_res_uuid = state.store_task_res(task_res)
 
-        if task_ins_id is not None:
-            task_res_list = state.get_task_res(task_ids={task_ins_id})
+        assert task_ins_id
+        task_res_list = state.get_task_res(task_ids={task_ins_id})
 
         # Assert
         retrieved_task_res = task_res_list[0]
@@ -811,8 +811,8 @@ def test_get_task_res_not_return_expired(self) -> None:
 
         with patch("time.time", side_effect=lambda: task_ins.task.created_at + 6.1):
             # Execute
-            if task_id is not None:
-                task_res_list = state.get_task_res(task_ids={task_id})
+            assert task_id is not None
+            task_res_list = state.get_task_res(task_ids={task_id})
 
             # Assert
             assert len(task_res_list) == 0
@@ -865,8 +865,8 @@ def test_get_task_res_return_if_not_expired(self) -> None:
 
         with patch("time.time", side_effect=lambda: task_ins.task.created_at + 6.1):
             # Execute
-            if task_id is not None:
-                task_res_list = state.get_task_res(task_ids={task_id})
+            assert task_id is not None
+            task_res_list = state.get_task_res(task_ids={task_id})
 
             # Assert
             assert len(task_res_list) != 0