Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets) Update tests for ted lium dataset #3868

Merged
merged 23 commits into from
Jul 22, 2024
Merged

feat(datasets) Update tests for ted lium dataset #3868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
efb2f40
Extend tested_datasets list
adam-narozniak Jul 17, 2024
016348b
Add femnist tests
adam-narozniak Jul 18, 2024
5292923
Add tests for ucf101 dataset
adam-narozniak Jul 18, 2024
b8a8387
Add tests for ambient acoustic context dataset
adam-narozniak Jul 18, 2024
9e46f0c
Add LIUM/tedlium as tested
adam-narozniak Jul 18, 2024
e9498a3
Update the tested dataset list
adam-narozniak Jul 18, 2024
ab67213
Merge branch 'main' into add-tests-for-ucf101-dataset
jafermarq Jul 18, 2024
ce8cc2d
Merge branch 'main' into add-tests-for-ambient-acoustic-context
adam-narozniak Jul 19, 2024
c4aafea
Fix formatting
adam-narozniak Jul 19, 2024
915a6f3
Add function to perform partial download of dataset for tests
adam-narozniak Jul 20, 2024
0e6891c
Merge branch 'add-fds-partial-download-for-tests' into add-tests-for-…
adam-narozniak Jul 20, 2024
e81680d
Add a function that handles multiple splits
adam-narozniak Jul 20, 2024
02e085f
Merge branch 'add-fds-partial-download-for-tests' into add-tests-for-…
adam-narozniak Jul 20, 2024
2e955c9
Mock ucf101 by partial download
adam-narozniak Jul 22, 2024
0550d9a
Merge branch 'add-tests-for-ucf101-dataset' into add-tests-for-ambien…
adam-narozniak Jul 22, 2024
303da2e
Mock ambient-acoustic-context by partial download
adam-narozniak Jul 22, 2024
bb538a1
Update tests
adam-narozniak Jul 22, 2024
e9f4eb8
Update tests for ted-lium
adam-narozniak Jul 22, 2024
a3cbf9a
Update list
adam-narozniak Jul 22, 2024
b0323e8
Merge branch 'main' into update-tests-for-ted-lium-dataset
jafermarq Jul 22, 2024
ffe8cce
Merge branch 'main' into update-tests-for-ted-lium-dataset
adam-narozniak Jul 22, 2024
8376d38
Remove unused code
adam-narozniak Jul 22, 2024
dca2b0a
Merge branch 'main' into update-tests-for-ted-lium-dataset
jafermarq Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion datasets/flwr_datasets/federated_dataset_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,11 @@ def test_mixed_type_partitioners_creates_from_int(self) -> None:
"flwrlabs/femnist",
]

mocked_natural_id_datasets = ["flwrlabs/ucf101", "flwrlabs/ambient-acoustic-context"]
mocked_natural_id_datasets = [
"flwrlabs/ucf101",
"flwrlabs/ambient-acoustic-context",
"LIUM/tedlium",
]


@parameterized_class(
Expand All @@ -415,6 +419,7 @@ def test_mixed_type_partitioners_creates_from_int(self) -> None:
("flwrlabs/femnist", "", "", "writer_id"),
("flwrlabs/ucf101", "test", None, "video_id"),
("flwrlabs/ambient-acoustic-context", "", None, "speaker_id"),
("LIUM/tedlium", "test", "release3", "speaker_id"),
],
)
class NaturalIdPartitionerIntegrationTest(unittest.TestCase):
Expand Down
2 changes: 1 addition & 1 deletion datasets/flwr_datasets/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"svhn",
"sentiment140",
"speech_commands",
"LIUM/tedlium", # Feature wise it's just like speech_commands
"LIUM/tedlium",
"flwrlabs/femnist",
"flwrlabs/ucf101",
"flwrlabs/ambient-acoustic-context",
Expand Down