feat(benchmarks) Add LLM evaluation pipeline for general NLP challenge #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-gao-GY
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
reviewed
Jul 11, 2024
There was a problem hiding this comment.
@yan-gao-GY, first pass is ready. I mostly left comments regarding the README.md files
There was a problem hiding this comment.
is it ok to host this .jsonl (and the other two) files. Do we need to add some license or acknowledgement? How do other repos do this?
There was a problem hiding this comment.
For OpenFedLLM, they just use it: https://github.com/rui-ye/OpenFedLLM/tree/main/evaluation/open_ended, but they have a Citation section at bottom
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
…o add-llm-nlp-eval
jafermarq
reviewed
Jul 31, 2024
There was a problem hiding this comment.
@yan-gao-GY i was reviewing it but i decided to present my suggestions as a PR (#3950) to your branch. Let me know what you think.
benchmarks/flowertune-llm/evaluation/general-nlp/gen_judgement.py
Outdated
Show resolved
Hide resolved
danieljanes
reviewed
Aug 9, 2024
danieljanes
reviewed
Aug 9, 2024
danieljanes
reviewed
Aug 9, 2024
jafermarq
previously approved these changes
Sep 2, 2024
jafermarq
reviewed
Sep 2, 2024
jafermarq
reviewed
Sep 2, 2024
jafermarq
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal