ci(*:skip) Add flower-simulation e2e tests #3747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnugraha
requested review from
Robert-Steiner,
tanertopal and
danieljanes
as code owners
danielnugraha
changed the title
…2e-next' into flower-simulation-e2e-next
…2e-next' into flower-simulation-e2e-next
tanertopal
reviewed
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
The new Flower Next is using
flower-simulationCLI command instead ofstart_simulationfunction call, but it's not reflected in e2e tests.Related issues/PRs
Proposal
Explanation
Add
flower-simulatione2e tests in test-simulation.sh. The e2e test directories are renamed to allowflower-simulationto use either the general server.py in parent directory or specific server.py in current directory.Checklist
#contributions)Any other comments?