Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(datasets) Fix docs examples formatting #3702

Merged
merged 3 commits into from
Jul 22, 2024
Merged

docs(datasets) Fix docs examples formatting #3702

merged 3 commits into from
Jul 22, 2024

Conversation

adam-narozniak
Copy link
Contributor

Issue

The examples shown in the docs of FederatedDataset and a few Partitioners are misformatted (due to the missing new line before the code section).

Proposal

  • Add new line when needed.
  • Add an example if the examples section is missing in the docs.

@adam-narozniak adam-narozniak marked this pull request as ready for review July 18, 2024 09:48
@jafermarq jafermarq enabled auto-merge (squash) July 22, 2024 15:55
@jafermarq jafermarq merged commit c4bb563 into main Jul 22, 2024
41 checks passed
@jafermarq jafermarq deleted the fds-update-partitioner-docs-examples branch July 22, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-narozniak @jafermarq