-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework) Add flwr log
#3577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jafermarq
reviewed
Jun 12, 2024
jafermarq
reviewed
Jun 12, 2024
Moep90
reviewed
Jul 30, 2024
jafermarq
reviewed
Aug 14, 2024
@jafermarq About your comments here, we need to refactor |
danieljanes
reviewed
Sep 19, 2024
danieljanes
reviewed
Sep 23, 2024
danieljanes
reviewed
Sep 23, 2024
danieljanes
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
With the
SuperExec
service, theServerApp
logs are not easily accessible. This CLI enables a request to be sent to the service.Related issues/PRs
The companion PR below adds log capturing to the SuperExec service. This PR can be merged independently of it.
Blocks:
flwr log
#3611flwr run
#3613Proposal
Explanation
flwr log
sends a requests to theSuperExec
service to get the log stream and receives a response from it. The response will be handled in two ways:flwr log <RUN_ID> <DIRECTORY> <FEDERATION_NAME>
. The default isstream=True
(--stream
). This streams the logs and periodically refreshes the gRPC connection.flwr log <RUN_ID> <DIRECTORY> <FEDERATION_NAME> --show
. This prints the logs and closes the connection gracefully. Every subsequent execution of this command always prints the logs from the beginning of the run.Checklist
#contributions
)Any other comments?