Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build versioned docs when publishing #3250

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

charlesbvll
Copy link
Member

Issue

Description

Currently, on every PR, we build full versioned docs to test the validity of the docs, this is not useful as previous versions of the docs won't be modified by main.

Related issues/PRs

N/A

Proposal

Explanation

Modify the dev/build-docs.sh script to take a versioned boolean argument and modify the docs workflow to only build versioned docs when publishing.

Checklist

  • Implement proposed change
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review April 12, 2024 12:14
@tanertopal tanertopal enabled auto-merge (squash) April 12, 2024 15:46
@tanertopal tanertopal merged commit ebd186d into main Apr 12, 2024
28 checks passed
@tanertopal tanertopal deleted the build-versioned-on-publish branch April 12, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants