Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double ping_interval field to PingRequest in fleet.proto. #3179

Merged
merged 1 commit into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/proto/flwr/proto/fleet.proto
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ message DeleteNodeRequest { Node node = 1; }
message DeleteNodeResponse {}

// Ping messages
message PingRequest { Node node = 1; }
message PingRequest {
Node node = 1;
double ping_interval = 2;
}
message PingResponse { bool success = 1; }

// PullTaskIns messages
Expand Down
36 changes: 18 additions & 18 deletions src/py/flwr/proto/fleet_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion src/py/flwr/proto/fleet_pb2.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,17 @@ class PingRequest(google.protobuf.message.Message):
"""Ping messages"""
DESCRIPTOR: google.protobuf.descriptor.Descriptor
NODE_FIELD_NUMBER: builtins.int
PING_INTERVAL_FIELD_NUMBER: builtins.int
@property
def node(self) -> flwr.proto.node_pb2.Node: ...
ping_interval: builtins.float
def __init__(self,
*,
node: typing.Optional[flwr.proto.node_pb2.Node] = ...,
ping_interval: builtins.float = ...,
) -> None: ...
def HasField(self, field_name: typing_extensions.Literal["node",b"node"]) -> builtins.bool: ...
def ClearField(self, field_name: typing_extensions.Literal["node",b"node"]) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["node",b"node","ping_interval",b"ping_interval"]) -> None: ...
global___PingRequest = PingRequest

class PingResponse(google.protobuf.message.Message):
Expand Down