Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inconsistent type hints #3148

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

charlesbvll
Copy link
Member

Issue

Description

When creating a Flower project using flwr new --framework pytorch, files for a default PyTorch project are created but the typing in them is inconsistent.

Related issues/PRs

N/A

Proposal

Explanation

Remove type hints, as these template should just provide a working project with the bare minimum.

Checklist

  • Implement proposed change
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

N/A

@danieljanes danieljanes merged commit d391fd6 into main Mar 14, 2024
28 checks passed
@danieljanes danieljanes deleted the pt-template-consistent-typing branch March 14, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants