Rename node_id to partition_id in Flower Datasets #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
previously approved these changes
Mar 13, 2024
danieljanes
previously approved these changes
Mar 13, 2024
adam-narozniak
dismissed stale reviews from danieljanes and jafermarq
via
7f10ebf
danieljanes
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
node_idparameter fromload_partitionfunction breaks abstaction. Partitioner does not know about any nodes. More accurate name ispartition_id.Also,
node_idrepresents different things in the core framework and works in accordance to this PR #3023.Proposal
Rename
node_idtopartition_id.Related PRs
(Mentioned in the Issue section) changes the
node_idtopartition_idin examples #3023Changelog entry