Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Fwd/Bwd with Message/Context #2842

Merged
merged 21 commits into from
Jan 29, 2024
Merged

Replace Fwd/Bwd with Message/Context #2842

merged 21 commits into from
Jan 29, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jan 23, 2024 •
edited
Loading

This PR excludes the update/injection of RunState inside the Context that goes through the middleware layers. After this PR another one will make the current RunState and NodeState definitions to operate on RecordSet.

@panh99 panh99 mentioned this pull request Jan 25, 2024
Merged
@danieljanes danieljanes changed the title Replace Fwd/Bwd with FlowerContext Replace Fwd/Bwd with Message/Context Jan 25, 2024
@jafermarq jafermarq changed the base branch from main to nodestate-with-recordset January 25, 2024 22:14
Base automatically changed from nodestate-with-recordset to main January 26, 2024 12:28
danieljanes
danieljanes reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove Fwd/Bwd?

danieljanes
danieljanes previously approved these changes Jan 27, 2024
View reviewed changes
danieljanes
danieljanes previously approved these changes Jan 27, 2024
View reviewed changes
@danieljanes danieljanes marked this pull request as ready for review January 29, 2024 10:41
@danieljanes danieljanes enabled auto-merge (squash) January 29, 2024 10:44
@danieljanes danieljanes merged commit 89c735a into main Jan 29, 2024
28 checks passed
@danieljanes danieljanes deleted the replace-fwd-bwd-flowercontext branch January 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jafermarq @danieljanes @panh99