Central DP (server-side fixed clipping) #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadnaseri
requested review from
danieljanes and
tanertopal
as code owners
jafermarq
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Hi @mohammadnaseri , just some initial comments below. My main concern is that because we need to apply multiple changes to the input parameters, they get copied several times. This might not be a problem with models but it will certainly be when having larger models or many clients. A few functions in common can be rewritten to prevent doing a copy. However, for aggregate_fit() it might not be so easy, but maybe with some reorganisation it can be done with just a single full copy of the parameters.
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
danieljanes
reviewed
Feb 14, 2024
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel J. Beutel <[email protected]>
Co-authored-by: Daniel J. Beutel <[email protected]>
danieljanes
reviewed
Feb 20, 2024
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
danieljanes
reviewed
Feb 20, 2024
src/py/flwr/server/strategy/dp_strategy_wrapper_fixed_clipping.py
Outdated
Show resolved
Hide resolved
danieljanes
reviewed
Feb 20, 2024
danieljanes
reviewed
Feb 20, 2024
danieljanes
reviewed
Feb 20, 2024
danieljanes
approved these changes
Feb 20, 2024
tanertopal
added a commit
that referenced
this pull request
Feb 20, 2024
…ate_docformatter * 'update_docformatter' of github.com:adap/flower: Fix small typos (#2986) Update models.py (#2985) Move `*Record` and `RecordSet` to `record` package (#2984) Improve `*Record` (#2982) Introduce central DP (server-side fixed clipping) (#2798) Apply suggestions from code review pin virtualenv version to 20.21.0 in baselines (#2981) Add `flwr` CLI (#2942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Central DP, also known as user-level DP, enables differential privacy strategies in Flower with server-side fixed clipping.
Related issues/PRs
Proposal
Explanation
A new class,
DifferentialPrivacyServerSideFixedClipping, has been added. It can be wrapped around a strategy class to enable central DP with fixed clipping. The clipping phase of clients' model updates is performed at the server side.Checklist
#contributions)Changelog entry
Any other comments?