-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FedAvgM strategy: Add Nesterov Accelerated Gradient (NAG) #2762
Open
gubertoli
wants to merge
19
commits into
adap:main
Choose a base branch
from
gubertoli:fedavgm-with-nesterov
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting validation dataset references on FlowerClient class and min_eval_clients to be in accordance with the comments.
To be compatible with sanity check for the return of fit method from clients (Tuple of list,int,dict) introduced on the last version of flower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
This PR improves the FedAvgM implementation FedAvgM introducing the Nesterov Accelerated Gradient (NAG), the same as reported in the original FedAvgM paper:
https://arxiv.org/pdf/1909.06335.pdf
Related issues/PRs
N/A
Proposal
Introduce the calculation of NAG as part of the global model parameters update.
Explanation
The improvement of the introduction of NAG is reported on the FedAvgM baseline:
https://github.com/adap/flower/tree/main/baselines/fedavgm#comparison-between-the-custom-fedavgm-and-fedavgm
Checklist
#contributions
)Changelog entry
Any other comments?
PR aligned with @jafermarq