Skip to content

Commit

Permalink
ci(framework) Extend tests for fab_hash (#4020)
Browse files Browse the repository at this point in the history
  • Loading branch information
charlesbvll authored Aug 15, 2024
1 parent 9c85be5 commit ead952b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
8 changes: 7 additions & 1 deletion src/py/flwr/server/driver/grpc_driver_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ class TestGrpcDriver(unittest.TestCase):
def setUp(self) -> None:
"""Initialize mock GrpcDriverStub and Driver instance before each test."""
mock_response = Mock(
run=Run(run_id=61016, fab_id="mock/mock", fab_version="v1.0.0")
run=Run(
run_id=61016,
fab_id="mock/mock",
fab_version="v1.0.0",
fab_hash="9f86d08",
)
)
self.mock_stub = Mock()
self.mock_channel = Mock()
Expand All @@ -55,6 +60,7 @@ def test_init_grpc_driver(self) -> None:
self.assertEqual(self.driver.run.run_id, 61016)
self.assertEqual(self.driver.run.fab_id, "mock/mock")
self.assertEqual(self.driver.run.fab_version, "v1.0.0")
self.assertEqual(self.driver.run.fab_hash, "9f86d08")
self.mock_stub.GetRun.assert_called_once()

def test_get_nodes(self) -> None:
Expand Down
4 changes: 2 additions & 2 deletions src/py/flwr/server/driver/inmemory_driver_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def setUp(self) -> None:
run_id=61016,
fab_id="mock/mock",
fab_version="v1.0.0",
fab_hash="hash",
fab_hash="9f86d08",
override_config={"test_key": "test_value"},
)
state_factory = MagicMock(state=lambda: self.state)
Expand All @@ -102,7 +102,7 @@ def test_get_run(self) -> None:
self.assertEqual(self.driver.run.run_id, 61016)
self.assertEqual(self.driver.run.fab_id, "mock/mock")
self.assertEqual(self.driver.run.fab_version, "v1.0.0")
self.assertEqual(self.driver.run.fab_hash, "hash")
self.assertEqual(self.driver.run.fab_hash, "9f86d08")
self.assertEqual(self.driver.run.override_config["test_key"], "test_value")

def test_get_nodes(self) -> None:
Expand Down

0 comments on commit ead952b

Please sign in to comment.