Skip to content

Commit

Permalink
add underscore to protected func
Browse files Browse the repository at this point in the history
  • Loading branch information
panh99 committed Jan 22, 2024
1 parent b226b61 commit b61fbb4
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions src/py/flwr/common/serde.py
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ def named_values_from_proto(
T = TypeVar("T")


def record_value_to_proto(
def _record_value_to_proto(
value: Any, allowed_types: List[type], proto_class: Type[T]
) -> T:
"""Serialize `*RecordValue` to ProtoBuf."""
Expand All @@ -618,7 +618,7 @@ def record_value_to_proto(
)


def record_value_from_proto(value_proto: Message) -> Any:
def _record_value_from_proto(value_proto: Message) -> Any:
"""Deserialize `*RecordValue` from ProtoBuf."""
value_field = cast(str, value_proto.WhichOneof("value"))
if value_field.endswith("list"):
Expand All @@ -628,22 +628,22 @@ def record_value_from_proto(value_proto: Message) -> Any:
return value


def record_value_dict_to_proto(
def _record_value_dict_to_proto(
value_dict: Dict[str, Any], allowed_types: List[type], value_proto_class: Type[T]
) -> Dict[str, T]:
"""Serialize the record value dict to ProtoBuf."""

def proto(_v: Any) -> T:
return record_value_to_proto(_v, allowed_types, value_proto_class)
return _record_value_to_proto(_v, allowed_types, value_proto_class)

return {k: proto(v) for k, v in value_dict.items()}


def record_value_dict_from_proto(
def _record_value_dict_from_proto(
value_dict_proto: MutableMapping[str, Any]
) -> Dict[str, Any]:
"""Deserialize the record value dict from ProtoBuf."""
return {k: record_value_from_proto(v) for k, v in value_dict_proto.items()}
return {k: _record_value_from_proto(v) for k, v in value_dict_proto.items()}


def array_to_proto(array: Array) -> ProtoArray:
Expand Down Expand Up @@ -684,7 +684,7 @@ def parameters_record_from_proto(
def metrics_record_to_proto(record: MetricsRecord) -> ProtoMetricsRecord:
"""Serialize MetricsRecord to ProtoBuf."""
return ProtoMetricsRecord(
data=record_value_dict_to_proto(
data=_record_value_dict_to_proto(
record.data, [float, int], ProtoMetricsRecordValue
)
)
Expand All @@ -695,7 +695,7 @@ def metrics_record_from_proto(record_proto: ProtoMetricsRecord) -> MetricsRecord
return MetricsRecord(
metrics_dict=cast(
Dict[str, typing.MetricsRecordValues],
record_value_dict_from_proto(record_proto.data),
_record_value_dict_from_proto(record_proto.data),
),
keep_input=False,
)
Expand All @@ -704,7 +704,7 @@ def metrics_record_from_proto(record_proto: ProtoMetricsRecord) -> MetricsRecord
def configs_record_to_proto(record: ConfigsRecord) -> ProtoConfigsRecord:
"""Serialize ConfigsRecord to ProtoBuf."""
return ProtoConfigsRecord(
data=record_value_dict_to_proto(
data=_record_value_dict_to_proto(
record.data, [int, float, bool, str, bytes], ProtoConfigsRecordValue
)
)
Expand All @@ -715,7 +715,7 @@ def configs_record_from_proto(record_proto: ProtoConfigsRecord) -> ConfigsRecord
return ConfigsRecord(
configs_dict=cast(
Dict[str, typing.ConfigsRecordValues],
record_value_dict_from_proto(record_proto.data),
_record_value_dict_from_proto(record_proto.data),
),
keep_input=False,
)

0 comments on commit b61fbb4

Please sign in to comment.