feat(framework) Update subprocess launch mechanism for simulation plu…

…gin (#3826) Signed-off-by: Danny Heinrich <[email protected]> Co-authored-by: Danny Heinrich <[email protected]>
adap · Jul 17, 2024 · a20e4c9 · a20e4c9
1 parent c6547ef
commit a20e4c9
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/py/flwr/superexec/simulation.py b/src/py/flwr/superexec/simulation.py
@@ -125,18 +125,17 @@ def start_run(
                 command.extend(["--run-config", f"{override_config}"])
 
             # Start Simulation
-            proc = subprocess.Popen(  # pylint: disable=consider-using-with
+            proc = subprocess.run(  # pylint: disable=consider-using-with
                 command,
-                stdout=subprocess.PIPE,
-                stderr=subprocess.PIPE,
+                check=True,
                 text=True,
             )
 
             log(INFO, "Started run %s", str(run_id))
 
             return RunTracker(
                 run_id=run_id,
-                proc=proc,
+                proc=proc,  # type:ignore
             )
 
         # pylint: disable-next=broad-except