New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare meta values before diffing them #29

Open

tschortsch wants to merge 1 commit into adamsilverstein:features/display-meta-on-revisions-ui from tschortsch:features/display-meta-on-revisions-ui

tschortsch commented Feb 27, 2017

I enhanced the meta diff UI to also work with multiple meta values for one field.


          prepare meta values before diffing them

285444a

Owner

adamsilverstein commented Dec 1, 2017

@tschortsch Thanks for the PR (and apologies for the delay in responding). I like the idea of providing these filters - how do you plan to use them?

Here is some feedback:

the filters shouldn't start with '_' this indicates an internal/private filter by convention
the filters need doc block - this would be a good place to explain how developers can use these filters
some unit tests that demonstrate how these filters work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet