Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all meta fields for a specific key get added to the revision #28

Open
wants to merge 2 commits into
base: fix-storage-as-array
Choose a base branch
from
Open

Ensure that all meta fields for a specific key get added to the revision #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9475a40
ensure that all meta fields for a specific key get added to the revision
tschortsch Feb 27, 2017
e26bbdd
fix restoring of meta fields
tschortsch Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions wp-post-meta-revisions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,15 @@ public function _wp_save_revisioned_meta_fields( $revision_id ) {
$post_id = $revision->post_parent;
// Save revisioned meta fields.
foreach ( $this->_wp_post_revision_meta_keys() as $meta_key ) {
$meta_value = get_post_meta( $post_id, $meta_key, true );
$meta_values = get_post_meta( $post_id, $meta_key );

/*
* Use the underlying add_metadata() function vs add_post_meta()
* to ensure metadata is added to the revision post and not its parent.
*/
add_metadata( 'post', $revision_id, $meta_key, $meta_value );
foreach( $meta_values as $meta_value ) {
/*
* Use the underlying add_metadata() function vs add_post_meta()
* to ensure metadata is added to the revision post and not its parent.
*/
add_metadata( 'post', $revision_id, $meta_key, $meta_value );
}
}
}

Expand All @@ -155,7 +157,7 @@ public function _wp_restore_post_revision_meta( $post_id, $revision_id ) {
// Clear any existing metas
delete_post_meta( $post_id, $meta_key );
// Get the stored meta, not stored === blank
$meta_values = get_post_meta( $revision_id, $meta_key, true );
$meta_values = get_post_meta( $revision_id, $meta_key );
if ( 0 !== sizeof( $meta_values ) && is_array( $meta_values ) ) {
foreach ( $meta_values as $meta_value ) {
add_post_meta( $post_id, $meta_key, $meta_value );
Expand Down