disable Self-Sizing

[RickeyBoy]

I met this Issue #6 and spent some time to fix this.

It turns out to be that in iOS 11.0 UITableViewAutomaticDimension is the default value of estimatedRowHeight rather than 0. In other words, we have to disable Self-Sizing manually.

In UITableViewAutomaticDimension mode, if we have to reuse cells, TableView is not able to get the right contentSize. While scrolling, new cells come out and cause changes of contentSize.

[adamshin]

Thanks for looking into this.. I'm not sure if this is the right solution here, though.

Like you mentioned, automatic cell sizing does cause issues with reordering. And in iOS 11 it looks like you have to manually disable it. But setting estimatedRowHeight to 0 is only part of that -- the user still needs to calculate and return a cell height in their tableView delegate method. We can't do that part automatically.

I'd lean towards adding a note in the documentation for this, so it's clear what the user needs to do (and why). If we do part of it automatically, but not the other part, I'm afraid it could lead to non-obvious issues when people try to use the library.

I'm seeing some other issues with iOS 11 as well... may need to take some time and look into things. 😞

[RickeyBoy]

Yeah, I know what you mean. It seems like that adding a note is a better way right now. 😊