Fix bug where child components would sometimes lose their action events.

adamghill · Jan 24, 2021 · 454cdf7 · 454cdf7
1 parent 1f814a4
commit 454cdf7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/django_unicorn/static/js/eventListeners.js b/django_unicorn/static/js/eventListeners.js
@@ -117,9 +117,7 @@ export function addActionEventListener(component, eventType) {
         const { action } = actionEvent;
         const { element } = actionEvent;
 
-        // TOD: Check why the targetElement needs to check isSameNode OR has the same
-        // key/id since `isSameNode` won't always work
-        if (targetElement.isSame(element) || targetElement.isSameId(element)) {
+        if (targetElement.isSame(element)) {
           // Add the value of any child element of the target that is a lazy model to the action queue
           // Handles situations similar to https://github.com/livewire/livewire/issues/528
           component.walker(element.el, (childEl) => {

diff --git a/django_unicorn/static/js/messageSender.js b/django_unicorn/static/js/messageSender.js
@@ -141,10 +141,12 @@ export function send(component, callback) {
             MORPHDOM_OPTIONS
           );
           parentComponent.refreshChecksum();
+          parentComponent.refreshEventListeners();
 
-          // parentComponent.getChildrenComponents().forEach((child) => {
-          //   child.refreshEventListeners();
-          // });
+          parentComponent.getChildrenComponents().forEach((child) => {
+            child.init();
+            child.refreshEventListeners();
+          });
         }
       }