Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for making MITMing selective depending on peer host/port #406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ScottDennison
Copy link

This is helpful when needing to deal with certificate pinned applications at the same time as the intended MITMable traffic, when both must use the same proxy.

Note: This pull request should be rejected if pull request #402 is merged first. #402 upgrades the java version of this project to 8, at which point it would be better to make shouldMITMPeer a default method inside MitmManager instead of in the extension interface SelectiveMitmManager.

… This is helpful when needing to deal with certificate pinned applications at the same time as the intended MITMable traffic, when both must use the same proxy.
@ScottDennison
Copy link
Author

The travis ci build for java 8 failed for this pull request, but succeeded in my repository (https://travis-ci.org/ScottDennison/LittleProxy/jobs/350944465), I'm not knowledgeable enough with travis ci to know why.

The travis ci build for java 7 fails in master already, and is also fixed by #402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant