Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7 asset scanning #55

Closed
wants to merge 7 commits into from
Closed

7 asset scanning #55

wants to merge 7 commits into from

Conversation

cherry-john
Copy link
Contributor

By submitting a PR for this repository you accept the contributor license agreement.

Description

Implements asset scanning to the v2 app, using @capacitor-community/barcode-scanner.
This scanning library only supports android and ios built apps currently, so users not on these platforms are given a prompt to input the barcode manually. This is an area to look into in the future.

Also adds buttons prop to the Page component, allowing buttons to be added to the end of the navbar on pages.
image

Buttons have been added to asset list (barcode search) and projects (supermarket sweep/add assets)

Also adds Function entry to the side menu listing, to allow functions like location setting and instance switching to be called in the same structure as current menu

References

closes #7
also helps towards #5 and #6

Checklist

  • I have added documentation for new/changed functionality in this PR or in the documentation repo
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@cherry-john cherry-john requested review from a team and Jbithell as code owners January 1, 2023 14:55
@netlify
Copy link

netlify bot commented Jan 1, 2023

Deploy Preview for adamrms-app ready!

Name Link
🔨 Latest commit 11cd49d
🔍 Latest deploy log https://app.netlify.com/sites/adamrms-app/deploys/63b1b1bbe33fa80008de8897
😎 Deploy Preview https://deploy-preview-55--adamrms-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 11cd49d
Status: ✅  Deploy successful!
Preview URL: https://63304b7a.adam-rms-v2.pages.dev
Branch Preview URL: https://7-asset-scanning.adam-rms-v2.pages.dev

View logs

@cherry-john cherry-john closed this Jan 2, 2023
@cherry-john cherry-john deleted the 7-asset-scanning branch January 2, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supermarket Sweep
1 participant