Skip to content

Reduce USB static buffers for ESP32-S2 #10293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 25, 2025

This frees up more RAM for other things.

RAM started overflowing with #10281

This frees up more RAM for other things.

RAM started overflowing with micropython#10281
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending it building (but several of the failing builds passed now so believe the rest will)

@Neradoc
Copy link

Neradoc commented Apr 25, 2025

Will downsizing the USB CDC buffer make #4817 happen on the S2 like it does on the SAMD21 ? (which also uses 128)
Where the buffer is filled fast and that makes ctrl-C ignored.

@tannewt
Copy link
Member Author

tannewt commented Apr 25, 2025

Will downsizing the USB CDC buffer make #4817 happen on the S2 like it does on the SAMD21 ? (which also uses 128) Where the buffer is filled fast and that makes ctrl-C ignored.

Yes, that will happen on the S2 just like on SAMD21.

@tannewt tannewt merged commit 36bc41c into adafruit:main Apr 25, 2025
247 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants