-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Two enhancements for Fruit Jam launcher #10238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1b5006a
to
0ffa06a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you missed the second commit.
1. Set working directory for subsequent file. 2. Add `pathlib` for easy file discovery.
@RetiredWizard Thanks for the additional comments. I'll need to be better about testing my Claude generated code. I've fixed in a slightly different way by fixing the QSTRs. |
I was planning on giving pathlib a pretty thorough workout by incorporating into the PyDOS directory system. Currently I'm using a Python workaround for the vfsFat mount point issue (can't traverse up a path to the root #8409) and was hoping that I might see a way to put the workaround in the pathlib core code. I'll probably put that on the back burner now though 😁 |
I'm not sure how the stem/name/suffix methods will be used but there were some minor differences in the results of paths that contained '.' or '..' elements between this version and cpython. Other than that, I gave most of the methods at least a brief test and everything seems to be working. |
Dan and I chatted about this and he pointed out that I do still want to fix the os implementation of cwd because pathlib will build on it and there are existing bugs filed for it. |
I'm going to close this and split it into to PRs:
|
pathlib
for easy file discovery.