Skip to content

Two enhancements for Fruit Jam launcher #10238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 8, 2025

  1. Set working directory for subsequent file.
  2. Add pathlib for easy file discovery.

@tannewt tannewt requested a review from dhalbert April 8, 2025 17:45
@tannewt tannewt force-pushed the pathlib branch 2 times, most recently from 1b5006a to 0ffa06a Compare April 8, 2025 18:22
Copy link

@RetiredWizard RetiredWizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed the second commit.

tannewt added 2 commits April 10, 2025 13:31
1. Set working directory for subsequent file.
2. Add `pathlib` for easy file discovery.
@tannewt
Copy link
Member Author

tannewt commented Apr 10, 2025

@RetiredWizard Thanks for the additional comments. I'll need to be better about testing my Claude generated code. I've fixed in a slightly different way by fixing the QSTRs.

@RetiredWizard
Copy link

RetiredWizard commented Apr 10, 2025

I was planning on giving pathlib a pretty thorough workout by incorporating into the PyDOS directory system. Currently I'm using a Python workaround for the vfsFat mount point issue (can't traverse up a path to the root #8409) and was hoping that I might see a way to put the workaround in the pathlib core code. I'll probably put that on the back burner now though 😁

@tannewt tannewt marked this pull request as ready for review April 14, 2025 20:45
@tannewt tannewt requested a review from RetiredWizard April 14, 2025 20:46
@RetiredWizard
Copy link

I'm not sure how the stem/name/suffix methods will be used but there were some minor differences in the results of paths that contained '.' or '..' elements between this version and cpython. Other than that, I gave most of the methods at least a brief test and everything seems to be working.

@tannewt
Copy link
Member Author

tannewt commented Apr 16, 2025

Dan and I chatted about this and he pointed out that pathlib could just be a Python library. In fact, micropython already has a simple version here: https://github.com/micropython/micropython-lib/blob/master/python-stdlib/pathlib/pathlib.py I'm going to take the native implementation out in favor of the Python one.

I do still want to fix the os implementation of cwd because pathlib will build on it and there are existing bugs filed for it.

@tannewt
Copy link
Member Author

tannewt commented Apr 16, 2025

I'm going to close this and split it into to PRs:

  • Adding working_directory
  • Fixing OS

@tannewt tannewt closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants