add, use a default __exit__ object
#10040
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
reviewed
Feb 7, 2025
|
That's a good question! I used a #define so that (I suspect but don't know for sure that It's super sus that this didn't build any boards! ci_set_matrix found the changed files but decided not to build any boards. from the build log: |
jepler
added a commit
to jepler/circuitpython
that referenced
this pull request
Feb 7, 2025
Recently in adafruit#10026 this script was altered so that sometimes items are removed from `boards`. However, this could have side effects. For instance, when a file like `shared/runtime/context_manager_helpers.c` is modified, it doesn't match any per-port or per-board rule so we execute `boards_to_build = all_board_ids`. But if the object `all_board_ids` refers to has been modified by `boards.remove(board)` in an earlier iteration, then we don't end up really building all boards. Noticed during development of adafruit#10040.
jepler
force-pushed
the
default_exit_obj
branch
from
5a79e13 to
392e777
Compare
This just delegates to .deinit(). Also, change default __enter__ to a macro that reuses the identically-beving "identity_obj", and harmonize a few sites so that the naming s consistent. Saves about 800 bytes on metro rp2350.
jepler
force-pushed
the
default_exit_obj
branch
from
392e777 to
8aa1969
Compare
There are more exeptions scattered across the codebase, but this is the only one that foiled my attempts to use grep to check that every object using default___exit___obj also had a deinit method.
dhalbert
requested changes
Feb 8, 2025
| @@ -259,7 +259,7 @@ static const mp_rom_map_elem_t _zephyr_serial_uart_locals_dict_table[] = { | |||
| { MP_ROM_QSTR(MP_QSTR___del__), MP_ROM_PTR(&_zephyr_serial_uart_deinit_obj) }, | |||
| { MP_ROM_QSTR(MP_QSTR_deinit), MP_ROM_PTR(&_zephyr_serial_uart_deinit_obj) }, | |||
| { MP_ROM_QSTR(MP_QSTR___enter__), MP_ROM_PTR(&default___enter___obj) }, | |||
| { MP_ROM_QSTR(MP_QSTR___exit__), MP_ROM_PTR(&_zephyr_serial_uart___exit___obj) }, | |||
| { MP_ROM_QSTR(MP_QSTR___exit__), MP_ROM_PTR(&default___exit___obj) }, | |||
There was a problem hiding this comment.
The zephyr_serial_uart___exit___ code was not deleted in this file. Did you mean to do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just delegates to .
deinit().Also, reuse
identity_objfor default__enter__.Saves about 800 bytes on metro rp2350.