Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api inconsistency about temperature units #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix api inconsistency about temperature units #87

wants to merge 3 commits into from

Commits on Oct 17, 2017

  1. Choose the degault temperature units 

    As to husky-dev/firebase-iot-codelab#3 there is
a strange design when temperature is read in Celsius by default and
heatIndex is computed in Farenheit by default.

This commit sets the default unit to Celsius for calculating heatIndex.
    @anxolerd
    anxolerd committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    d4a877c View commit details
    Browse the repository at this point in the history

  2. Use better naming for S flag when reading temperature 

    S == Scale does not clearly represents the flag purpose. Rename it to
isFarenheit so it describes the flag purpose more precise
    @anxolerd
    anxolerd committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    a80367c View commit details
    Browse the repository at this point in the history

  3. Modify the example to reflect recent changes in code

    @anxolerd
    anxolerd committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    cfb8fd5 View commit details
    Browse the repository at this point in the history