Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PCA9547D devices #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Pyetrek
Copy link

@Pyetrek Pyetrek commented Jan 3, 2025

Hello, I have a project where I am using the PCA9547D mux with a couple nau7802s. Turns out the PCA9547's control register works a bit differently, so I created a couple of subclasses to handle that. I hope this is useful to others!

@FoamyGuy
Copy link
Contributor

I think typically we would want something like this to be a separate library. That way on devices with limited RAM we can minimize the amount of unused code that is loaded into memory for any given project. The separate library can list this one as a requirement and still extend the superclass from here.

We also have some infrastructure pieces that assume scripts in the examples/ directory will begin with the same base name as the library they belong to. i.e. for Adafruit_CircuitPython_TCA9548A all of the examples should begin with the prefix tca9548a_ Though I do see there are already some examples with different names existing there now.

@Pyetrek
Copy link
Author

Pyetrek commented Jan 22, 2025

Hi @FoamyGuy, thanks for the response. I can setup a new library with this code included. Is adafruit interested in owning said repository or will it remain 3rd party?

@FoamyGuy
Copy link
Contributor

@Pyetrek Usually we would only own the library if it supports a piece of Adafruit hardware. Other wise it can be added to the Community Bundle which is published alongside the Adafruit one and libraries within it are available with tooling like circup.

You could ask in the #circuitpython-dev channel on discord, or during the "in the weeds" section of the weekly meeting on a Monday if you'd like to see if anyone has other ideas for how to publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants