check is_connected in loop() #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Makes sense, and looks good to me. Thanks for tracking it down and adding the check @vladak!
I did a quick test of an example script on a Fun House and it's working as expected. I also confirmed calling loop() before connect() results in the exception being raised.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 21, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.1.10 from 3.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#45 from dertobias/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.4.4 from 7.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#174 from vladak/loop_is_connected Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone hit a None-deref when calling
loop()without callingconnect()first. This change checks the connected status in loop() and raises exception if not connected.