Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for small 0.66" 64x48 OLED #38

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

asmagill
Copy link
Contributor

@asmagill asmagill commented Jan 4, 2024

Adds displayio support for 0.66" 64x48 OLED displays. Works for 0 and 180 rotation; I suspect 90/270 requires additional changes in logic deeper in displayio and I don't require this yet, so I haven't pursued it.

Tested with https://www.amazon.com/gp/product/B07QF7QK6P/ref=ppx_yo_dt_b_search_asin_title?ie=UTF8&psc=1 (currently unavailable) and a replacement screen (same logic board) from https://www.buydisplay.com/small-0-66-inch-white-64x48-oled-display-module-ssd1306-serial-spi-i2c.

@dglaude
Copy link
Contributor

dglaude commented Jan 4, 2024

I think you should also update the documentation part on the top of the file to say that it is now working with 64x48 and the link you provided. It is the "Hardware" section.

Please notice that I have burned my 0.49'' 64x32 and I have no way to test anymore if the code continue to work. Also, I am almost sure I never tested rotation in my code, so it is great that you tested at least some (180) of the rotation in this update.

@tannewt
Copy link
Member

tannewt commented Jan 17, 2024

Please use pre-commit to standardize the formatting: https://learn.adafruit.com/improve-your-code-with-pylint/check-your-code-with-pre-commit

@asmagill
Copy link
Contributor Author

% pre-commit run --all-files
black....................................................................Passed
reuse....................................................................Passed
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
pylint (library code)....................................................Passed
pylint (example code)....................................................Passed
pylint (test code)...................................(no files to check)Skipped

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 76dd808 into adafruit:main Jan 19, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 23, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.8.0 from 1.7.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#38 from asmagill/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.5 from 5.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#134 from AdamCummick/correct-mac-error
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#137 from us3r64/fix/wsgiserver
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#139 from us3r64/fix/socket-recv-recv_into

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.8.2 from 2.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#69 from Karel-Kroeze/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniQR to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#28 from jamesbowman/main
  > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#26 from jamesbowman/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants