Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for another 160x80 module #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

xcqq
Copy link

@xcqq xcqq commented Apr 19, 2020

The module is used on M5StickC, BGR inverted, x offset 26, y offset 1.

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process.

Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

The module is used on M5StickC, BGR inverted, x offset 26, y offset 1.
@ladyada
Copy link
Member

ladyada commented Apr 19, 2020

i think it may be better to use M5STICK_ rather than GREENTAB_ cause the tab colors change

@KurtE
Copy link
Contributor

KurtE commented Apr 20, 2020

Hope you don't mind me adding comment...

But trying out some third party 160x80 display (form digikey) with this library as well as my own, nothing works yet, so thought I would try your changes... Still does not work.

But thought I would mention, that if this PR is taken, Whatever the accepted name is for the init parameter, you probably should add it to the keywords.txt file as well.

@xcqq
Copy link
Author

xcqq commented Apr 20, 2020

i think it may be better to use M5STICK_ rather than GREENTAB_ cause the tab colors change

Yes, it's a good idea to make the name better for understanding. But actually, I'm not very clear about the meaning of 'tab colors'. Could you explain more about this?

Hope you don't mind me adding comment...

But trying out some third party 160x80 display (form digikey) with this library as well as my own, nothing works yet, so thought I would try your changes... Still does not work.

But thought I would mention, that if this PR is taken, Whatever the accepted name is for the init parameter, you probably should add it to the keywords.txt file as well.

I'm not sure if we are using the same display... The display can be found on Taobao(in China) and seems also available on eBay. But I can't tell the difference in appearance, they are just look the same. Anyway, I have done some test with the M5StickC:
1abdc570a0eb279fd9d43726b09408a
5f1894d538f675fc77cc10789c53ba7
ea10c7c13bf67312914215208a36e44
94714a74b2c4f0e770017550e48b5e4

I'm not always doing my work on arduino, and for my understanding, the keywords.txt file is used to highlight some keywords of the library, is that right? But I can't find this file in this repo...

@KurtE
Copy link
Contributor

KurtE commented Apr 22, 2020

Just an FYI - I just updated our Teensy derivative library (https://github.com/PaulStoffregen/ST7735_t3) to maybe support this display. The actual one I tested on was the one sold by both Digikey and Mouser. (https://www.digikey.com/product-detail/en/PIM436/1778-PIM436-ND/)

More details up on the PJRC forum thread: https://forum.pjrc.com/threads/59880-In-ST7735_t3-tft-Print-and-tft-Println-do-not-print-spaces?p=236539&viewfull=1#post236539

Note: I gave the tab name a rather long name: INITR_MINI160x80_ST7735S
I believe my changes are consistent with the python version of the library for this display:
https://github.com/cskau/Python_ST7735

Side note: I also fixed our support for the Adafruit small ST7789 display which I picked up at the same time from Digikey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants