Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up development environment with uv pip #60

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Set up development environment with uv pip #60

wants to merge 7 commits into from

Conversation

bbayles
Copy link
Collaborator

@bbayles bbayles commented Mar 12, 2024

This PR changes our Makfile to use uv pip instead of pip.

Resolves #58

anonrig
anonrig reviewed Mar 12, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Mar 12, 2024
View reviewed changes
Makefile Outdated
.PHONY: requirements
ci_requirements:
python3 -m pip install uv
python3 -m uv pip install --system -r requirements/development.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3 -m uv pip install --system -r requirements/development.txt
uv pip install --system -r requirements/development.txt

anonrig
anonrig reviewed Mar 12, 2024
View reviewed changes
Makefile Outdated
.PHONY: requirements
requirements:
python3 -m pip install uv
python3 -m pip install -r requirements/development.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be changed as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have it this way to avoid making assumptions about the user's virtual environment setup. It's fine for our CI target, though.

@bbayles bbayles marked this pull request as draft March 12, 2024 14:55
@bbayles bbayles mentioned this pull request Mar 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use uv
2 participants
@bbayles @anonrig