* don't notify on entries made by yourself

ad · May 23, 2018 · b79c073 · b79c073
1 parent 3ac0260
commit b79c073
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 19 deletions.
diff --git a/GitHubListener/AppDelegate.swift b/GitHubListener/AppDelegate.swift
@@ -52,7 +52,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate, NSUserNotificationCent
         if let accessToken = self.defaults.string(forKey: "GHL.access_token") {
             self.accessToken = accessToken
 
-            print("access_token read", accessToken)
+//            print("access_token read", accessToken)
             if let username = self.defaults.string(forKey: "GHL.username") {
                 self.username = username
                 updateData()
@@ -204,9 +204,13 @@ final class AppDelegate: NSObject, NSApplicationDelegate, NSUserNotificationCent
                                     let testDate:Date = commit.description.author.date
                                     if (date != nil && date != testDate) {
                                         if (commit.description.verification.verified) {
-                                            self.showNotification(title: "\(repo.fullName)", subtitle: "\(commit.author.login) added commit", informativeText:  commit.description.message, image: commit.author.avatarUrl, url: commit.htmlUrl)
+                                            if self.username != commit.author.login { // TODO: make it customizable
+                                                self.showNotification(title: "\(repo.fullName)", subtitle: "\(commit.author.login) added commit", informativeText:  commit.description.message, image: commit.author.avatarUrl, url: commit.htmlUrl)
+                                            }
                                         } else {
-                                            self.showNotification(title: "\(repo.fullName)", subtitle: "\(commit.description.author.name) added commit", informativeText:  commit.description.message, url: commit.htmlUrl)
+                                            if self.username != commit.description.author.name { // TODO: make it customizable
+                                                self.showNotification(title: "\(repo.fullName)", subtitle: "\(commit.description.author.name) added commit", informativeText:  commit.description.message, url: commit.htmlUrl)
+                                            }
                                         }
                                     }
                                 }

diff --git a/GitHubListener/Info.plist b/GitHubListener/Info.plist
@@ -17,7 +17,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>0.3</string>
+	<string>0.4</string>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 	<key>LSApplicationCategoryType</key>

diff --git a/build.sh b/build.sh
@@ -1,26 +1,24 @@
 #!/bin/bash
 
-NAME='GitHubListener'
-
-rm -rf Release 2>/dev/null
+rm -r Release 2>/dev/null
 
 xcodebuild archive \
-	-scheme "$NAME" \
-	-archivePath Release/App.xcarchive
+    -scheme "GitHubListener" \
+    -archivePath Release/App.xcarchive
 
 xcodebuild \
-	-exportArchive \
-	-archivePath Release/App.xcarchive \
-	-exportOptionsPlist export-options.plist \
-	-exportPath Release
+    -exportArchive \
+    -archivePath Release/App.xcarchive \
+    -exportOptionsPlist export-options.plist \
+    -exportPath Release
 
 cd Release
 rm -r App.xcarchive
+sleep 2
 
-sleep 5
-
-VER=`mdls -raw -name kMDItemVersion $NAME.app`
+# Prerequisite: npm i -g create-dmg
+# create-dmg "${NAME}.app"
 
-ARCH_NAME="$NAME.v$VER.zip"
-zip -r $ARCH_NAME $NAME.app
-# echo "$ARCH_NAME"
+VERSION=`mdls -raw -name kMDItemVersion GitHubListener.app`
+echo $VERSION
+zip -r "GitHubListener.v$VERSION.zip" "GitHubListener.app"