-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement lazy join #1524
Open
RobinTF
wants to merge
37
commits into
ad-freiburg:master
Choose a base branch
from
RobinTF:lazy-join
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,192
−207
Open
Implement lazy join #1524
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
1840f4c
Make stuff static or const where possible
RobinTF a287bf3
Cleanup join code
RobinTF 1cc9f8b
Extend BlockZipperJoinImpl to handle undef values correctly
RobinTF 2f3f4fa
Remove redundant semicolons
RobinTF 56d334a
Fix condition
RobinTF d9bccea
Make first prototype for lazy joins
RobinTF 243ea2b
Add comment and try to fix warnings in clang
RobinTF 465baa2
Add Unit tests for join algorithm
RobinTF 3508a92
Properly call flush
RobinTF b77230e
Fix testing code
RobinTF 01e2d8e
Add another unit test and fix bug
RobinTF 856c91c
Merge remote-tracking branch 'ad-freiburg/master' into lazy-join
RobinTF 6e5558e
Split up code into dedicated functions
RobinTF 2834a28
Reuse code and fix sonarcloud issues
RobinTF 1a74800
Make join with undef work
RobinTF 7ef6b5b
Simplify functions further
RobinTF 64d404d
Allow lazy generator output of join
RobinTF ac63c9c
Skip undefined if guaranteed to be undefined
RobinTF 1fdec46
Use contract check instead of correctness check
RobinTF 4baaf81
Add some tests and fix lifetime issues with coroutines
RobinTF 831507b
Merge remote-tracking branch 'ad-freiburg/master' into lazy-join
RobinTF c6f0525
Add more unit tests
RobinTF fefe3bb
Generalize interfaces and unify code
RobinTF 5b91fb1
Don't repeat code
RobinTF 4d535a8
Fix typo
RobinTF 9fe9ef2
Adjust tests to cover their intended code
RobinTF 3ac9faf
Optimize code again for coverage
RobinTF b9f2594
Fix some sonarcloud issues
RobinTF 3c2a473
Use helper function to consume single-step generator
RobinTF 9a379ce
Merge remote-tracking branch 'ad-freiburg/master' into lazy-join
RobinTF b7536c4
Generalize interface for monostate conversion
RobinTF 1733d27
Allow IndexScan optimizations to yield lazy generators
RobinTF fd0b633
Remove unused member from join class
RobinTF 0f83805
Improve partial coverage a bit
RobinTF bc09d1e
Add variants of test cases for greater coverage
RobinTF 3db3229
Merge branch 'master' into lazy-join
RobinTF e43ff76
Merge remote-tracking branch 'ad-freiburg/master' into lazy-join
RobinTF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some documentation, what do those functions do?