-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support update #126
base: master
Are you sure you want to change the base?
Support update #126
Conversation
requires that qlever also accepts the access token from the authorization header file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-1 with Julian, looks great and works, thanks a lot!
It would be great to show a meaningful message (like: "Update successful") when the update was successful (no need to display the JSON for this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-1 with Julian, this looks great and works. A few suggestions for improvement:
- Remove the extra space before the "Automatically add names ..."
- Add button for "Clear delta triples" and "Clear cache complete"
- Add some more information to the "Update successful" message
NOTE: There already is a field for the access token (called API token) in the backend config as well as buttons for clear cache etc.
The whole warmup functionality is broken quite much (see #130). Fixing that that is out of scope, so I won't add a corresponding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thorough 1-1 with Julian, this is great and works fine now. A few more glitches:
- Functionality of the new buttons: when successful after the red x, the spinning wheel icon disappears completely
- When buttons are displayed the whole column moves to the left; more padding
- Number of inserted triples is 0 although it isn't (maybe same for delete triples)
Could also be made to work with the current setup of having the access token as a query parameter.
Currently depends on ad-freiburg/qlever#1691, but it could also be done without this PR by adding the access token to the parameters.
Closes #122.