Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update #126

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Support update #126

wants to merge 14 commits into from

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Jan 19, 2025

Could also be made to work with the current setup of having the access token as a query parameter.
Currently depends on ad-freiburg/qlever#1691, but it could also be done without this PR by adding the access token to the parameters.

Closes #122.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Julian, looks great and works, thanks a lot!

It would be great to show a meaningful message (like: "Update successful") when the update was successful (no need to display the JSON for this PR).

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Julian, this looks great and works. A few suggestions for improvement:

  1. Remove the extra space before the "Automatically add names ..."
  2. Add button for "Clear delta triples" and "Clear cache complete"
  3. Add some more information to the "Update successful" message

NOTE: There already is a field for the access token (called API token) in the backend config as well as buttons for clear cache etc.

@Qup42
Copy link
Member Author

Qup42 commented Feb 8, 2025

  1. The Clear delta triples button currently is reported as having had an error, because the response is not JSON but plain text. I'll change the response the response to JSON in QLever.

The whole warmup functionality is broken quite much (see #130). Fixing that that is out of scope, so I won't add a corresponding Clear delta triples button in the Django Admin in this PR:

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorough 1-1 with Julian, this is great and works fine now. A few more glitches:

  1. Functionality of the new buttons: when successful after the red x, the spinning wheel icon disappears completely
  2. When buttons are displayed the whole column moves to the left; more padding
  3. Number of inserted triples is 0 although it isn't (maybe same for delete triples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sparql update - Provide token
2 participants