Correct link to translation setup for local install #4353
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
jfdoming
changed the title
WalkthroughThe pull request updates the URL of the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/desktop-client/src/components/settings/LanguageSettings.tsx (1)
74-80: Consider using more descriptive link text for better accessibility.Instead of using "here" as the link text, consider using a more descriptive text that explains where the link leads to. This improves accessibility for screen reader users.
- <Link - variant="external" - to="https://actualbudget.org/docs/install/local#translations" - > - here - </Link>{' '} - to add missing translation files. + <Link + variant="external" + to="https://actualbudget.org/docs/install/local#translations" + > + in the translation setup guide + </Link>{' '} + to add missing translation files.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/4353.mdis excluded by!**/*.md
📒 Files selected for processing (1)
packages/desktop-client/src/components/settings/LanguageSettings.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Visual regression
- GitHub Check: Functional
- GitHub Check: build (macos-latest)
- GitHub Check: build (windows-latest)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (2)
packages/desktop-client/src/components/settings/LanguageSettings.tsx (2)
76-76: LGTM! Documentation link updated correctly.The URL change to the translations section in the local installation documentation is accurate and aligns with the PR objectives.
76-76: Verify the documentation URL is accessible.Let's ensure the new documentation URL is accessible and returns a valid response.
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Check if the documentation URL is accessible curl -I "https://actualbudget.org/docs/install/local#translations"Length of output: 880
Documentation URL is Accessible
The URL returns an HTTP/2 301 redirect to
/docs/install/local/, which indicates that it is accessible. This behavior is standard for resources that have been permanently moved.
Link to actualbudget/docs#630